[
https://issues.apache.org/jira/browse/KAFKA-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240282#comment-16240282
]
ASF GitHub Bot commented on KAFKA-6164:
---------------------------------------
GitHub user rajinisivaram opened a pull request:
https://github.com/apache/kafka/pull/4181
KAFKA-6164: Shutdown quota managers if other components fail to start
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rajinisivaram/kafka KAFKA-6164
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/4181.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4181
----
commit 9c11aa563fe320c60aa3d75b34d5d368bf0bad0b
Author: Rajini Sivaram <rajinisiva...@googlemail.com>
Date: 2017-11-06T10:49:21Z
KAFKA-6164: Shutdown quota managers if other components fail to start
----
> ClientQuotaManager threads prevent shutdown when encountering an error
> loading logs
> -----------------------------------------------------------------------------------
>
> Key: KAFKA-6164
> URL: https://issues.apache.org/jira/browse/KAFKA-6164
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.11.0.0, 1.0.0
> Reporter: Xavier Léauté
> Assignee: Rajini Sivaram
>
> While diagnosing KAFKA-6163, we noticed that when the broker initiates a
> shutdown sequence in response to an error loading the logs, the process never
> exits. The JVM appears to be waiting indefinitely for several non-deamon
> threads to terminate.
> The threads in question are {{ThrottledRequestReaper-Request}},
> {{ThrottledRequestReaper-Produce}}, and {{ThrottledRequestReaper-Fetch}}, so
> it appears we don't properly shutdown {{ClientQuotaManager}} in this
> situation.
> QuotaManager shutdown is currently handled by KafkaApis, however KafkaApis
> will never be instantiated in the first place if we encounter an error
> loading the logs, so quotamangers are left dangling in that case.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
