[
https://issues.apache.org/jira/browse/KAFKA-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260173#comment-16260173
]
ASF GitHub Bot commented on KAFKA-4857:
---------------------------------------
GitHub user mjsax opened a pull request:
https://github.com/apache/kafka/pull/4242
KAFKA-4857: [WIP] Replace StreamsKafkaClient with AdminClient in Kafka
Streams
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/kafka kafka-4857-admit-client
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/4242.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4242
----
commit aad938f9cb3b5dce2824be9c9b3aff00068a6bbf
Author: Matthias J. Sax <matth...@confluent.io>
Date: 2017-11-21T02:17:57Z
KAFKA-4857: Replace StreamsKafkaClient with AdminClient in Kafka Streams
----
> Replace StreamsKafkaClient with AdminClient in Kafka Streams
> ------------------------------------------------------------
>
> Key: KAFKA-4857
> URL: https://issues.apache.org/jira/browse/KAFKA-4857
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
>
> Streams uses {{KafkaClientSupplier}} to get
> consumer/restore-consumer/producer clients. Streams also uses one more client
> for admin purpose namely {{StreamsKafkaClient}} that is instantiated
> "manually".
> With the newly upcoming {{AdminClient}} from KIP-117, we can simplify (or
> even replace {{StreamsKafkaClient}} with the new {{AdminClient}}. We
> furthermore want to unify how the client in generated and extend
> {{KafkaClientSupplier}} with method that return this client.
> NOTE: The public facing changes are summarized in a separate ticket
> KAFKA-6170, and this ticket is only for the internal swap, with the accepted
> criterion to completely remove StreamsKafkaClient with the newly introduced
> KafkaAdminClient.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
