[
https://issues.apache.org/jira/browse/KAFKA-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301912#comment-16301912
]
ASF GitHub Bot commented on KAFKA-2617:
---------------------------------------
guozhangwang commented on issue #338: KAFKA-2617: Move protocol field default
values to Protocol.
URL: https://github.com/apache/kafka/pull/338#issuecomment-353669036
Closing for cleanup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Move protocol field default values to Protocol
> ----------------------------------------------
>
> Key: KAFKA-2617
> URL: https://issues.apache.org/jira/browse/KAFKA-2617
> Project: Kafka
> Issue Type: Bug
> Reporter: Guozhang Wang
> Assignee: Jakub Nowak
> Priority: Minor
> Labels: newbie
>
> Right now the default values are scattered in the Request / Response classes,
> and some duplicates already exists like JoinGroupRequest.UNKNOWN_CONSUMER_ID
> and OffsetCommitRequest.DEFAULT_CONSUMER_ID. We would like to move all
> default values into org.apache.kafka.common.protocol.Protocol since
> org.apache.kafka.common.requests depends on org.apache.kafka.common.protocol
> anyways.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
