[
https://issues.apache.org/jira/browse/KAFKA-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charly Molter updated KAFKA-6180:
---------------------------------
Description:
AbstractConfig.getList returns null if the property is unset and there's no
default.
This creates a lot of cases where we need to do null checks (and remember them).
It's good practice to just return an empty list as usually code naturally
handles empty lists.
To do this we set the default on lists to be Collections.emptyList() and add a
Validator to disallow null values.
was:
AbstractConfig.getList returns null if the property is unset and there's no
default.
This creates a lot of cases where we need to do null checks (and remember them).
It's good practice to just return an empty list as usually code naturally
handles empty lists.
Summary: Add a Validator for NonNull configurations and remove
redundant null checks on lists (was: AbstractConfig.getList() should never
return null)
> Add a Validator for NonNull configurations and remove redundant null checks
> on lists
> ------------------------------------------------------------------------------------
>
> Key: KAFKA-6180
> URL: https://issues.apache.org/jira/browse/KAFKA-6180
> Project: Kafka
> Issue Type: Improvement
> Components: config
> Affects Versions: 0.10.1.0, 0.10.1.1, 0.10.2.0, 0.10.2.1, 0.11.0.0, 1.0.0
> Reporter: Charly Molter
> Priority: Trivial
>
> AbstractConfig.getList returns null if the property is unset and there's no
> default.
> This creates a lot of cases where we need to do null checks (and remember
> them).
> It's good practice to just return an empty list as usually code naturally
> handles empty lists.
> To do this we set the default on lists to be Collections.emptyList() and add
> a Validator to disallow null values.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
