[
https://issues.apache.org/jira/browse/KAFKA-5624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318774#comment-16318774
]
ASF GitHub Bot commented on KAFKA-5624:
---------------------------------------
omkreddy opened a new pull request #4404: KAFKA-5624: Add expiry check to
sensor.add() methods
URL: https://github.com/apache/kafka/pull/4404
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unsafe use of expired sensors
> -----------------------------
>
> Key: KAFKA-5624
> URL: https://issues.apache.org/jira/browse/KAFKA-5624
> Project: Kafka
> Issue Type: Bug
> Reporter: Jason Gustafson
>
> Seems a couple unhandled cases following sensor expiration:
> 1. Static sensors (such as {{ClientQuotaManager.delayQueueSensor}}) can be
> expired due to inactivity, but the references will remain valid and usable.
> Probably a good idea to either ensure we use a "get or create" pattern when
> accessing the sensor or add a new static registration option which makes the
> sensor ineligible for expiration.
> 2. It is possible to register metrics through the sensor even after it is
> expired. We should probably raise an exception instead.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
