[
https://issues.apache.org/jira/browse/KAFKA-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329547#comment-16329547
]
ASF GitHub Bot commented on KAFKA-6302:
---------------------------------------
mjsax closed pull request #4332: KAFKA-6302: Improve AdmintClient JavaDocs
URL: https://github.com/apache/kafka/pull/4332
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/clients/src/main/java/org/apache/kafka/clients/admin/AdminClient.java
b/clients/src/main/java/org/apache/kafka/clients/admin/AdminClient.java
index abe666a4387..897e127d557 100644
--- a/clients/src/main/java/org/apache/kafka/clients/admin/AdminClient.java
+++ b/clients/src/main/java/org/apache/kafka/clients/admin/AdminClient.java
@@ -105,7 +105,7 @@ public CreateTopicsResult createTopics(Collection<NewTopic>
newTopics) {
*
* This operation is not transactional so it may succeed for some topics
while fail for others.
*
- * It may take several seconds after this method returns
+ * It may take several seconds after {@code CreateTopicsResult} returns
* success for all the brokers to become aware that the topics have been
created.
* During this time, {@link AdminClient#listTopics()} and {@link
AdminClient#describeTopics(Collection)}
* may not return information about the new topics.
@@ -138,7 +138,7 @@ public DeleteTopicsResult deleteTopics(Collection<String>
topics) {
*
* This operation is not transactional so it may succeed for some topics
while fail for others.
*
- * It may take several seconds after AdminClient#deleteTopics returns
+ * It may take several seconds after the {@code DeleteTopicsResult} returns
* success for all the brokers to become aware that the topics are gone.
* During this time, AdminClient#listTopics and AdminClient#describeTopics
* may continue to return information about the deleted topics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Topic can not be recreated after it is deleted
> ----------------------------------------------
>
> Key: KAFKA-6302
> URL: https://issues.apache.org/jira/browse/KAFKA-6302
> Project: Kafka
> Issue Type: Bug
> Components: admin, clients
> Affects Versions: 1.0.0
> Reporter: kic
> Assignee: Matthias J. Sax
> Priority: Major
> Fix For: 1.1.0, 1.0.1
>
>
> I use an embedded kafka for unit test. My application relies on the ability
> to recreate topics programmatically. Currently it is not possible to
> re-create a topic after it has been deleted.
> {code}
> // needs compile time depedency
> 'net.manub:scalatest-embedded-kafka_2.11:1.0.0' and
> 'org.apache.kafka:kafka-clients:1.0.0'
> package kic.kafka.embedded
> import java.util.Properties
> import org.apache.kafka.clients.admin.{AdminClient, NewTopic}
> import org.scalatest._
> import scala.collection.JavaConverters._
> class EmbeddedKafaJavaWrapperTest extends FlatSpec with Matchers {
> val props = new Properties()
> val testTopic = "test-topic"
> "The admin client" should "be able to create, delete and re-create topics"
> in {
> props.setProperty("bootstrap.servers", "localhost:10001")
> props.setProperty("delete.enable.topic", "true")
> props.setProperty("group.id", "test-client")
> props.setProperty("key.deserializer",
> "org.apache.kafka.common.serialization.LongDeserializer")
> props.setProperty("value.deserializer",
> "org.apache.kafka.common.serialization.StringDeserializer")
> props.setProperty("clinet.id", "test-client")
> props.setProperty("key.serializer",
> "org.apache.kafka.common.serialization.LongSerializer")
> props.setProperty("value.serializer",
> "org.apache.kafka.common.serialization.StringSerializer")
> EmbeddedKafaJavaWrapper.start(10001, 10002, props)
> try {
> implicit val admin = AdminClient.create(props)
> // create topic and confirm it exists
> createTopic(testTopic)
> val topics = listTopics()
> info(s"topics: $topics")
> topics should contain(testTopic)
> // now we should be able to send something to this topic
> // TODO create producer and send something
> // delete topic
> deleteTopic(testTopic)
> listTopics() shouldNot contain(testTopic)
> // recreate topic
> createTopic(testTopic)
> // listTopics() should contain(testTopic)
> // and finally consume from the topic and expect to get 0 entries
> // TODO create consumer and poll once
> } finally {
> EmbeddedKafaJavaWrapper.stop()
> }
> }
> def listTopics()(implicit admin: AdminClient) =
> admin.listTopics().names().get()
> def createTopic(topic: String)(implicit admin: AdminClient) =
> admin.createTopics(Seq(new NewTopic(topic, 1, 1)).asJava)
> def deleteTopic(topic: String)(implicit admin: AdminClient) =
> admin.deleteTopics(Seq("test-topic").asJava).all().get()
> }
> {code}
> Btw, what happens to connected producers/consumers when I delete a topic?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
