[ https://issues.apache.org/jira/browse/KAFKA-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333322#comment-16333322 ]
Yu LIU commented on KAFKA-2200: ------------------------------- Hello [~becket_qin], I'm new to Kafka. I just have a look at this and I may have some questions. So we are not going to call {code:java}callback.onCompletion(null, e);{code} in order to not to break the "callback execution order" ? then ApiException is caught, intead of sending a [FutureFailure of ApiException|https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java#L847], we'll deal with it separately by a new ClientTimeoutException and RecordTooLargeException, so in this two case, we are still going to send it back within a FutureFailure ? Thx in advance. > kafkaProducer.send() should not call callback.onCompletion() > ------------------------------------------------------------ > > Key: KAFKA-2200 > URL: https://issues.apache.org/jira/browse/KAFKA-2200 > Project: Kafka > Issue Type: Bug > Components: clients > Affects Versions: 0.10.1.0 > Reporter: Jiangjie Qin > Priority: Major > Labels: newbie > Fix For: 1.1.0 > > > KafkaProducer.send() should not call callback.onCompletion() because this > might break the callback firing order. -- This message was sent by Atlassian JIRA (v7.6.3#76005)