junrao commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r887161032
##########
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##########
@@ -888,24 +975,25 @@ class ReplicaFetcherThreadTest {
def
shouldCatchExceptionFromBlockingSendWhenShuttingDownReplicaFetcherThread():
Unit = {
val props = TestUtils.createBrokerConfig(1, "localhost:1234")
val config = KafkaConfig.fromProps(props)
- val mockBlockingSend: BlockingSend = mock(classOf[BlockingSend])
+ val mockBlockingSend: BlockingSend = mock(classOf[BlockingSend])
+ when(mockBlockingSend.brokerEndPoint()).thenReturn(brokerEndPoint)
when(mockBlockingSend.initiateClose()).thenThrow(new
IllegalArgumentException())
when(mockBlockingSend.close()).thenThrow(new IllegalStateException())
+
val replicaManager: ReplicaManager = mock(classOf[ReplicaManager])
when(replicaManager.brokerTopicStats).thenReturn(mock(classOf[BrokerTopicStats]))
- val thread = new ReplicaFetcherThread(
- name = "bob",
- fetcherId = 0,
- sourceBroker = brokerEndPoint,
- brokerConfig = config,
- failedPartitions = failedPartitions,
- replicaMgr = replicaManager,
- metrics = new Metrics(),
- time = new SystemTime(),
- quota = null,
- leaderEndpointBlockingSend = Some(mockBlockingSend))
+
Review Comment:
extra new line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
