mumrah commented on code in PR #12182:
URL: https://github.com/apache/kafka/pull/12182#discussion_r887242125
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -139,22 +139,17 @@ public class ReplicationControlManager {
static final int MAX_ELECTIONS_PER_IMBALANCE = 1_000;
static class Builder {
- private Supplier<MetadataVersion> metadataVersion =
MetadataVersion::latest;
private SnapshotRegistry snapshotRegistry = null;
private LogContext logContext = null;
private short defaultReplicationFactor = (short) 3;
private int defaultNumPartitions = 1;
private int maxElectionsPerImbalance = MAX_ELECTIONS_PER_IMBALANCE;
+ private FeatureControlManager featureControlManager;
Review Comment:
Need FeatureControlManager instead of just a supplier since we need the
metadata.version at a particular epoch when creating the snapshot iterator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
