jnh5y commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r887251426
########## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskExecutionMetadataTest.java: ########## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.processor.internals; + +import static org.apache.kafka.streams.processor.internals.TopologyMetadata.UNNAMED_TOPOLOGY; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +import java.util.Arrays; +import java.util.Collections; +import java.util.HashSet; +import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; +import org.apache.kafka.streams.processor.TaskId; +import org.junit.Assert; +import org.junit.Test; + +public class TaskExecutionMetadataTest { + final static String TOPOLOGY1 = "topology1"; + final static String TOPOLOGY2 = "topology2"; + final static Set<String> NAMED_TOPOLOGIES = new HashSet<>(Arrays.asList(TOPOLOGY1, TOPOLOGY2)); + + @Test + public void testCanProcessWithoutNamedTopologies() { + final Set<String> topologies = Collections.singleton(UNNAMED_TOPOLOGY); + final Set<String> pausedTopologies = ConcurrentHashMap.newKeySet(); + + final TaskExecutionMetadata metadata = new TaskExecutionMetadata(topologies, + pausedTopologies); + + final Task mockTask = createMockTask(UNNAMED_TOPOLOGY); + + Assert.assertTrue(metadata.canProcessTask(mockTask, 0)); + // This pauses an UNNAMED_TOPOLOGY / a KafkaStreams instance without named/modular + // topologies. + pausedTopologies.add(UNNAMED_TOPOLOGY); + Assert.assertFalse(metadata.canProcessTask(mockTask, 0)); + } + + @Test + public void testNamedTopologiesCanBePausedIndependently() { + final Set<String> pausedTopologies = ConcurrentHashMap.newKeySet(); + final TaskExecutionMetadata metadata = new TaskExecutionMetadata(NAMED_TOPOLOGIES, + pausedTopologies); + + final Task mockTask1 = createMockTask(TOPOLOGY1); + final Task mockTask2 = createMockTask(TOPOLOGY2); + + Assert.assertTrue(metadata.canProcessTask(mockTask1, 0)); + Assert.assertTrue(metadata.canProcessTask(mockTask2, 0)); + + pausedTopologies.add(TOPOLOGY1); + Assert.assertFalse(metadata.canProcessTask(mockTask1, 0)); + Assert.assertTrue(metadata.canProcessTask(mockTask2, 0)); + + pausedTopologies.remove(TOPOLOGY1); + Assert.assertTrue(metadata.canProcessTask(mockTask1, 0)); + Assert.assertTrue(metadata.canProcessTask(mockTask2, 0)); + } + + @Test + public void testNamedTopologiesCanBeStartedPaused() { + final Set<String> pausedTopologies = ConcurrentHashMap.newKeySet(); + pausedTopologies.add(TOPOLOGY1); + + final TaskExecutionMetadata metadata = new TaskExecutionMetadata(NAMED_TOPOLOGIES, + pausedTopologies); + + final Task mockTask1 = createMockTask(TOPOLOGY1); + final Task mockTask2 = createMockTask(TOPOLOGY2); + + Assert.assertFalse(metadata.canProcessTask(mockTask1, 0)); + Assert.assertTrue(metadata.canProcessTask(mockTask2, 0)); + + pausedTopologies.remove(TOPOLOGY1); + Assert.assertTrue(metadata.canProcessTask(mockTask1, 0)); + Assert.assertTrue(metadata.canProcessTask(mockTask2, 0)); + } + + @Test + public void testNamedTopologiesCanBackoff() { + final Set<String> pausedTopologies = ConcurrentHashMap.newKeySet(); + + final TaskExecutionMetadata metadata = new TaskExecutionMetadata(NAMED_TOPOLOGIES, + pausedTopologies); + + final Task mockTask1 = createMockTask(TOPOLOGY1); + final Task mockTask2 = createMockTask(TOPOLOGY2); + + Assert.assertTrue(metadata.canProcessTask(mockTask1, 0)); + Assert.assertTrue(metadata.canProcessTask(mockTask2, 0)); + + metadata.registerTaskError(mockTask1, new Throwable("Error"), 0); + // One second after the error, task1 cannot process, task2 can. + Assert.assertFalse(metadata.canProcessTask(mockTask1, 1000)); + Assert.assertTrue(metadata.canProcessTask(mockTask2, 1000)); + Review Comment: Fixed in https://github.com/apache/kafka/pull/12161/commits/cfb18f5b61401c28d30a67ac4fbc8d0c1f12ce6f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
