[ 
https://issues.apache.org/jira/browse/KAFKA-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17547916#comment-17547916
 ] 

Luke Chen commented on KAFKA-13598:
-----------------------------------

[~d-t-w] , let's open a PR to Kafka repo first, we can discuss how to phrase it 
there. And then open a PR to kafka-site after merged.

For the points 1-4, I'm thinking we should make it into a sentence.

This is the current note for v3.2.0 related to this issue:

_Notable changes in 3.2.0_

    _- Idempotence for the producer is enabled by default if no conflicting 
configurations are set. In 3.0.0 and 3.1.0, a bug prevented this default from 
being applied, which meant that idempotence remained disabled unless the user 
had explicitly set enable.idempotence to true (See KAFKA-13598 for more 
details). This issue was fixed and the default is properly applied in 3.0.1, 
3.1.1, and 3.2.0._

 

I'm thinking you can add a sub-bullet after it, ex:

_Notable changes in 3.2.0_

    _- Idempotence for the producer is enabled by default if no conflicting 
configurations are set. In 3.0.0 and 3.1.0, a bug prevented this default from 
being applied, which meant that idempotence remained disabled unless the user 
had explicitly set enable.idempotence to true (See KAFKA-13598 for more 
details). This issue was fixed and the default is properly applied in 3.0.1, 
3.1.1, and 3.2.0._

           _-- When the broker version is lower than 2.8.0, and the client 
version is_ _3.0.1, 3.1.1, and later, the IDEMPOTENT_WRITE permission is 
required to produce data._

 

Something like that. Again, we can discuss it in the PR. Thank you.

 

> idempotence producer is not enabled by default if not set explicitly
> --------------------------------------------------------------------
>
>                 Key: KAFKA-13598
>                 URL: https://issues.apache.org/jira/browse/KAFKA-13598
>             Project: Kafka
>          Issue Type: Bug
>          Components: clients, config
>    Affects Versions: 3.1.0, 3.0.0
>            Reporter: Luke Chen
>            Assignee: Luke Chen
>            Priority: Major
>             Fix For: 3.0.1, 3.2.0, 3.1.1
>
>
> In KAFKA-10619, we intended to enable idempotence by default, but this was 
> not achieved due to a bug in the config validation logic. The change from 
> acks=1 to acks=all worked correctly, however.
> This is the following up for KIP-679: 
> [https://cwiki.apache.org/confluence/display/KAFKA/KIP-679%3A+Producer+will+enable+the+strongest+delivery+guarantee+by+default]
>  
> Note: In KAFKA-13673, we'll disable idempotent producer when 
> acks/retries/max.in.flight config conflicts, to avoid breaking existing 
> producers.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to