[GitHub] [kafka] mumrah commented on a diff in pull request #12258: MINOR: Convert `ReassignPartitionsIntegrationTest` to KRaft

[GitBox]

mumrah commented on code in PR #12258:
URL: https://github.com/apache/kafka/pull/12258#discussion_r890611619


##########
core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala:
##########
@@ -582,7 +598,7 @@ class ReassignPartitionsIntegrationTest extends 
QuorumTestHarness {
       case (brokerId, rack) =>
         val config = TestUtils.createBrokerConfig(
           nodeId = brokerId,
-          zkConnect = zkConnect,
+          zkConnect = zkConnectOrNull,

Review Comment:
   I wonder how hard it would be to convert `createBrokerConfig` to take an 
Option here instead of a null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org