jsancio commented on code in PR #12181:
URL: https://github.com/apache/kafka/pull/12181#discussion_r894086515
##########
core/src/main/scala/kafka/server/MetadataCache.scala:
##########
@@ -58,6 +58,10 @@ trait MetadataCache {
def hasAliveBroker(brokerId: Int): Boolean
+ def isBrokerFenced(brokerId: Int): Boolean
+
+ def isBrokerInControlledShutdown(brokerId: Int): Boolean
Review Comment:
I should have been more accurate with my comment. I was thinking that it may
be safer to only have these methods in `KRaftMetadataCache`.
`isBrokerIsrEligible` would check the type and call those methods if it is
right type. We wold also document this complexity in that method:
`isBrokerIsrEligible`.
I wanted to protect us from other future code from using these methods by
accident.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
