acsaki commented on code in PR #12179:
URL: https://github.com/apache/kafka/pull/12179#discussion_r894353596
##########
clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslServerAuthenticator.java:
##########
@@ -673,30 +673,26 @@ private long
calcCompletionTimesAndReturnSessionLifetimeMs() {
Long credentialExpirationMs = (Long) saslServer
.getNegotiatedProperty(SaslInternalConfigs.CREDENTIAL_LIFETIME_MS_SASL_NEGOTIATED_PROPERTY_KEY);
Long connectionsMaxReauthMs =
connectionsMaxReauthMsByMechanism.get(saslMechanism);
- if (credentialExpirationMs != null || connectionsMaxReauthMs !=
null) {
+ boolean maxReauthSet = connectionsMaxReauthMs != null &&
connectionsMaxReauthMs > 0;
Review Comment:
Thank you! Some tests are failing on my machine also but pass when I run
them in the IDE. :( Might be some flakiness but I'm looking into it right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
