dongjinleekr commented on code in PR #11579:
URL: https://github.com/apache/kafka/pull/11579#discussion_r895018539


##########
gradle/spotbugs-exclude.xml:
##########
@@ -28,8 +28,19 @@ For a detailed description of spotbugs bug categories, see 
https://spotbugs.read
         <!-- Disable warnings about mutable objects and the use of public 
fields.
             EI_EXPOSE_REP: May expose internal representation by returning 
reference to mutable object
             EI_EXPOSE_REP2: May expose internal representation by 
incorporating reference to mutable object
+            MS_EXPOSE_REP: Public static method may expose internal 
representation by returning array

Review Comment:
   1. Public static 
`org.apache.kafka.server.metrics.KafkaYammerMetrics.defaultRegistry()` may 
expose internal representation by returning 
`KafkaYammerMetrics.metricsRegistry`.
   2. Public static 
`org.apache.kafka.common.security.auth.SecurityProtocol.names()` may expose 
internal representation by returning `SecurityProtocol.NAMES`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to