divijvaidya commented on code in PR #12045:
URL: https://github.com/apache/kafka/pull/12045#discussion_r897721779
##########
clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java:
##########
@@ -149,13 +149,14 @@ private void verifyStats(Function<KafkaMetric, Double>
metricValueFunc) {
assertEquals(5.0,
metricValueFunc.apply(metrics.metric(metrics.metricName("s2.total", "grp1"))),
EPS,
"s2 reflects the constant value");
- assertEquals(4.5,
metricValueFunc.apply(metrics.metric(metrics.metricName("test.avg", "grp1"))),
EPS,
+ assertEquals(sum / (double) count,
metricValueFunc.apply(metrics.metric(metrics.metricName("test.avg", "grp1"))),
EPS,
"Avg(0...9) = 4.5");
assertEquals(count - 1,
metricValueFunc.apply(metrics.metric(metrics.metricName("test.max", "grp1"))),
EPS,
"Max(0...9) = 9");
assertEquals(0.0,
metricValueFunc.apply(metrics.metric(metrics.metricName("test.min", "grp1"))),
EPS,
"Min(0...9) = 0");
- assertEquals(sum / elapsedSecs,
metricValueFunc.apply(metrics.metric(metrics.metricName("test.rate", "grp1"))),
EPS,
+ // rate is calculated over the first ever window. Hence, we assume
presence of prior windows with 0 recorded events.
+ assertEquals((double) sum / elapsedSecs,
metricValueFunc.apply(metrics.metric(metrics.metricName("test.rate", "grp1"))),
EPS,
Review Comment:
Thanks for catching this. I have fixed this in the latest revision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
