mjsax commented on code in PR #12204:
URL: https://github.com/apache/kafka/pull/12204#discussion_r898406030
##########
streams/src/main/java/org/apache/kafka/streams/state/SessionStore.java:
##########
@@ -39,6 +39,13 @@
*/
public interface SessionStore<K, AGG> extends StateStore,
ReadOnlySessionStore<K, AGG> {
+ // TODO: javadoc; both ends are inclusive
+ default KeyValueIterator<Windowed<K>, AGG> findSessions(final Instant
earliestSessionEndTime,
Review Comment:
I think there is no way around it? In the end, we allow users to plugin a
custom session-store -- thus, if the use the new emit-final, why will need to
implement this new method -- existing code with custom session-stores should
not break, because existing code does neither implement but also not sure this
new method.
If we don't make it public API, we would prevent users to pass in custom
session-stores in combination with the new emit-final feature, what seems to be
too restrictive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
