dajac commented on code in PR #12298:
URL: https://github.com/apache/kafka/pull/12298#discussion_r898908914
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##########
@@ -478,8 +478,13 @@ boolean joinGroupIfNeeded(final Timer timer) {
resetJoinGroupFuture();
synchronized (AbstractCoordinator.this) {
- rejoinReason = String.format("rebalance failed due to '%s'
(%s)", exception.getMessage(), exception.getClass().getSimpleName());
- rejoinNeeded = true;
+ final String shortReason = String.format("rebalance failed
due to an exception: (%s)",
+ exception.getMessage(),
Review Comment:
@jnh5y If I understand correctly, you are saying that
`exception.getMessage()` contained the stack trace. Am I right? I wonder why.
Usually, the message is not suppose to contain it, no? It is a bit annoying
because we are losing information without the message here.
nit: You pass two arguments but have only one `%s` in the pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
