dajac commented on PR #12298: URL: https://github.com/apache/kafka/pull/12298#issuecomment-1160230612
> > I wonder if we should limit the reason when we build JoinGroupRequestData. We could pick the first 255 chars for instance. That would prevent us from hitting this in the future. I am not sure what a good limit would be. > > @dajac is there a specific reason you propose 255? Has this to do with the size of the entire request? If yes, on what does the size of the request depend on besides the reason? Is there a way to calculate how long the reason can be? > > I am not familiar with the error this the too long reason caused, so bear with me, if those are stupid question. No specific reason for the proposed 255. My reasoning is that the reason should be rather small. We have actually two upper bounds: 1) the `reason` field's length is limited to `0x7fff`, and 2) the require size could also be limited on the broker side. I am actually surprised that we hit 1) here. I think keeping the first 250 (or even 500) characters of the `reason` should be informative enough on the broker side and that would avoid being subject to hitting 1) in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
