cadonna commented on code in PR #12312:
URL: https://github.com/apache/kafka/pull/12312#discussion_r905099278
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##########
@@ -603,6 +655,178 @@ public void shouldDrainFailedTasksAndExceptions() throws
Exception {
verifyDrainingExceptionsAndFailedTasks(expectedExceptionAndTasks2,
expectedExceptionAndTasks3, expectedExceptionAndTasks4);
}
+ @Test
+ public void shouldGetTasksFromInputQueue() {
+ stateUpdater.shutdown(Duration.ofMillis(Long.MAX_VALUE));
+ stateUpdater = new DefaultStateUpdater(
+ changelogReader,
+ offsetResetter,
+ Time.SYSTEM,
+ true
+ );
+ final StreamTask activeTask1 =
createActiveStatefulTaskInStateRestoring(TASK_0_0,
Collections.singletonList(TOPIC_PARTITION_A_0));
+ final StreamTask activeTask2 =
createActiveStatefulTaskInStateRestoring(TASK_1_0,
Collections.singletonList(TOPIC_PARTITION_B_0));
+ final StandbyTask standbyTask1 =
createStandbyTaskInStateRunning(TASK_0_2,
Collections.singletonList(TOPIC_PARTITION_C_0));
+ final StandbyTask standbyTask2 =
createStandbyTaskInStateRunning(TASK_1_1,
Collections.singletonList(TOPIC_PARTITION_D_0));
+ final StandbyTask standbyTask3 =
createStandbyTaskInStateRunning(TASK_0_1,
Collections.singletonList(TOPIC_PARTITION_A_1));
+ stateUpdater.add(activeTask1);
+ stateUpdater.add(standbyTask1);
+ stateUpdater.add(standbyTask2);
+ stateUpdater.remove(TASK_0_0);
+ stateUpdater.add(activeTask2);
+ stateUpdater.add(standbyTask3);
+
+ final Set<Task> tasks = stateUpdater.getTasks();
+
+ assertEquals(5, tasks.size());
+ assertTrue(tasks.containsAll(mkSet(activeTask1, activeTask2,
standbyTask1, standbyTask2, standbyTask3)));
+
+ final Set<StreamTask> activeTasks = stateUpdater.getActiveTasks();
+
+ assertEquals(2, activeTasks.size());
+ assertTrue(activeTasks.containsAll(mkSet(activeTask1, activeTask2)));
+
+ final Set<StandbyTask> standbyTasks = stateUpdater.getStandbyTasks();
+
+ assertEquals(3, standbyTasks.size());
+ assertTrue(standbyTasks.containsAll(mkSet(standbyTask1, standbyTask2,
standbyTask3)));
+ }
+
+ @Test
+ public void shouldGetTasksFromUpdatingTasks() throws Exception {
+ final StreamTask activeTask1 =
createActiveStatefulTaskInStateRestoring(TASK_0_0,
Collections.singletonList(TOPIC_PARTITION_A_0));
+ final StreamTask activeTask2 =
createActiveStatefulTaskInStateRestoring(TASK_1_0,
Collections.singletonList(TOPIC_PARTITION_B_0));
+ final StandbyTask standbyTask1 =
createStandbyTaskInStateRunning(TASK_0_2,
Collections.singletonList(TOPIC_PARTITION_C_0));
+ final StandbyTask standbyTask2 =
createStandbyTaskInStateRunning(TASK_1_1,
Collections.singletonList(TOPIC_PARTITION_D_0));
+ final StandbyTask standbyTask3 =
createStandbyTaskInStateRunning(TASK_0_1,
Collections.singletonList(TOPIC_PARTITION_A_1));
+ when(changelogReader.completedChangelogs())
+ .thenReturn(Collections.emptySet());
+ when(changelogReader.allChangelogsCompleted())
+ .thenReturn(false);
+ stateUpdater.add(activeTask1);
+ stateUpdater.add(standbyTask1);
+ stateUpdater.add(standbyTask2);
+ stateUpdater.add(activeTask2);
+ stateUpdater.add(standbyTask3);
+ verifyUpdatingTasks(activeTask1, activeTask2, standbyTask1,
standbyTask2, standbyTask3);
+
+ final Set<Task> tasks = stateUpdater.getTasks();
+
+ assertEquals(5, tasks.size());
+ assertTrue(tasks.containsAll(mkSet(activeTask1, activeTask2,
standbyTask1, standbyTask2, standbyTask3)));
+
+ final Set<StreamTask> activeTasks = stateUpdater.getActiveTasks();
+
+ assertEquals(2, activeTasks.size());
+ assertTrue(activeTasks.containsAll(mkSet(activeTask1, activeTask2)));
+
+ final Set<StandbyTask> standbyTasks = stateUpdater.getStandbyTasks();
+
+ assertEquals(3, standbyTasks.size());
+ assertTrue(standbyTasks.containsAll(mkSet(standbyTask1, standbyTask2,
standbyTask3)));
+ }
+
+ @Test
+ public void shouldGetTasksFromRestoredActiveTasks() throws Exception {
Review Comment:
Good idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
