vvcephei opened a new pull request, #12342:
URL: https://github.com/apache/kafka/pull/12342

   Benchmarking indicates that #12049 was responsible for a 10% performance 
regression in the Producer. We are not sure why, but reverting the commit shows 
a return to nominal performance, so there is a strong indication that this one 
commit is indeed the culprit.
   
   Results:
   Commit: e3202b9999 (the parent of the problematic commit)
   TPut: 118k±1k
   
   Commit: f7db6031b8 (#12049)
   TPut: 106k±1k
   
   (every commit that we have tested from trunk after f7db6031b8 is also around 
106k)
   
   This PR, reverting f7db6031b8
   TPut: 116k±1k
   
   We propose to first revert the commit in question and then re-introduce the 
feature later, rather than trying to debug and fix the feature in trunk. The 
longer this commit stays live, the more code will be based on it, and the 
harder it will be in the future to extract, debug, or fix it.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to