showuon commented on code in PR #12347: URL: https://github.com/apache/kafka/pull/12347#discussion_r920088305
########## core/src/main/scala/kafka/log/LogManager.scala: ########## @@ -317,6 +338,11 @@ class LogManager(logDirs: Seq[File], val offlineDirs = mutable.Set.empty[(String, IOException)] val jobs = ArrayBuffer.empty[Seq[Future[_]]] var numTotalLogs = 0 + val curNumRecoveryThreadsPerDataDir = numRecoveryThreadsPerDataDir + // log dir path -> number of Remaining logs map for remainingLogsToRecover metric + val numRemainingLogs: ConcurrentMap[String, Int] = new ConcurrentHashMap[String, Int] + // log recovery thread name -> number of remaining segments map for remainingSegmentsToRecover metric + val numRemainingSegments: ConcurrentMap[String, Int] = new ConcurrentHashMap[String, Int] Review Comment: Change to local variables in `loadLogs` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org