C0urante opened a new pull request, #12409:
URL: https://github.com/apache/kafka/pull/12409

   [Jira](https://issues.apache.org/jira/browse/KAFKA-14058)
   
   Some notes:
   
   1. Introduced new `ConcurrencyUtils` and `MockitoUtils` classes for reusable 
testing logic that will likely be used in the near future for 
[KAFKA-14059](https://issues.apache.org/jira/browse/KAFKA-14059) and 
[KAFKA-14060](https://issues.apache.org/jira/browse/KAFKA-14060).
   2. Refactored a lot of common logic into dedicated methods, which reduces 
test size and should make tests easier to write.
   3. Doubled the default record batch size from 1 to 2. This provides better 
coverage and, after all the refactoring from step 2, required no modifications 
to mocking, verification, or assertion logic anywhere in the test suite.
   4. Stopped inheriting from the `ThreadedTest` class as it does nothing.
   5. Once this looks good enough to merge, I'll begin applying the same 
changes to the `WorkerSourceTaskTest` and possibly 
`AbstractWorkerSourceTaskTest` test suites.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to