[
https://issues.apache.org/jira/browse/KAFKA-6486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379625#comment-16379625
]
ASF GitHub Bot commented on KAFKA-6486:
---------------------------------------
asutosh936 opened a new pull request #4628: KAFKA-6486 - Implemented
HashLinkedMap in TimeWindows
URL: https://github.com/apache/kafka/pull/4628
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> TimeWindows causes unordered calls to windowed aggregation functions
> --------------------------------------------------------------------
>
> Key: KAFKA-6486
> URL: https://issues.apache.org/jira/browse/KAFKA-6486
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Affects Versions: 1.0.0
> Reporter: Valentino Proietti
> Priority: Minor
> Attachments: KAFKA-6486.patch
>
>
> This is not a real bug but it causes some weird behaviour, at least in my
> opinion.
> The TimeWindows has a method called windowsFor() that uses and returns an
> HashMap:
> @Override
> *public* Map<Long, TimeWindow> windowsFor(*final* *long* timestamp) {
> *long* windowStart = (Math._max_(0, timestamp - sizeMs + advanceMs) /
> advanceMs) * advanceMs;
> *final* Map<Long, TimeWindow> windows = *new* HashMap<>();
> ....
> the HashMap does not preserve the order of insertion and this ends up later
> in calls to any streams windowed aggregation functions that are not ordered
> by window time as I would expect.
> A simple solution is to replace the HashMap with a LinkedHashMap and that's
> what I did.
> Anyway replacing it directly in your code can save hours of debugging to
> understand what's happening.
> Thank you
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
