divijvaidya commented on code in PR #12441:
URL: https://github.com/apache/kafka/pull/12441#discussion_r933077759
##########
build.gradle:
##########
@@ -1832,12 +1840,17 @@ project(':streams') {
// testCompileOnly prevents streams from exporting a dependency on
test-utils, which would cause a dependency cycle
testCompileOnly project(':streams:test-utils')
+ // KAFKA-14109
+ // The below compileOnly dependency is needed for JUnit 4 tests.
+ // It can be safely removed once all of streams has moved to JUnit 5.
+ testCompileOnly libs.junit4
+
testImplementation project(':clients').sourceSets.test.output
testImplementation project(':core')
testImplementation project(':core').sourceSets.test.output
testImplementation libs.log4j
- testImplementation libs.junitJupiterApi
- testImplementation libs.junitVintageEngine
+ testImplementation libs.junitJupiter
+ testImplementation libs.junitJupiterParams // needed for parameterized
tests
Review Comment:
I have removed this right now to keep this PR simple. Will add when needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
