AlanConfluent commented on PR #12458: URL: https://github.com/apache/kafka/pull/12458#issuecomment-1205864412
> Thanks @AlanConfluent ! A few meta questions: > > 1. Seems the `streams_cooperative_rebalance_upgrade_test.py` is not included in this PR? I didn't update any of the upgrade tests just yet. I was having a hard time running against different versions of Kafka and using KRaft -- this seems like a reasonable followup, so I didn't do it yet. > 2. I think for `streams_application_upgrade_test.py` we should also consider enabling kraft on the servers, to make sure that kraft works when streams itself upgrade. I agree. This will be a followup. > 3. In `streams_broker_compatibility_test.py` when we test for broker versions > 3.1 we should also allow it to be kraft. Maybe this was the main issue I was running into. I thought KRaft was available in earlier versions, but saw odd failures. I'll talk to you about what it would take to get this working. > 4. This is not related to this PR, but it seems the test coverage for `streams_application_ugprade_test` and `streams_upgrade_test` have much overlaps. @vvcephei could you chime in here since you have much experience with the former class file. Could we dedup their coverage hence reduce our test time? > 5. If the current e2e time is too high, I feel maybe we can skip adding the kraft model for the following suite: > a. shutdown_deadlock > b. relational_smoke, since its dependency on kraft is exactly covered by smoke -- i.e. if there's an issue with relational_smoke due to kraft, then smoke itself should fail as well. > c. named_repartition Good to consider. Let's evaluate after I get a successful run of trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
