mimaison commented on code in PR #12046:
URL: https://github.com/apache/kafka/pull/12046#discussion_r942490893
##########
server-common/src/main/java/org/apache/kafka/server/metrics/KafkaYammerMetrics.java:
##########
@@ -53,16 +72,21 @@ public static MetricsRegistry defaultRegistry() {
}
private final MetricsRegistry metricsRegistry = new MetricsRegistry();
- private final FilteringJmxReporter jmxReporter = new
FilteringJmxReporter(metricsRegistry,
- metricName -> true);
+ private FilteringJmxReporter jmxReporter;
private KafkaYammerMetrics() {
- jmxReporter.start();
Review Comment:
Looking at this further I'm not sure this is the best way to make this work.
I wonder if we should apply the same treatment to `kafka.metrics.reporters` as
we're doing to `metric.reporters`. The issue is that `FilteringJmxReporter`
does not implement `KafkaMetricsReporter` but instead has its own API (based on
Yammer's `JmxReporter`) so this would require quite a bit of changes.
The other alternative is to not handle these Yammer reporters as the KIP
only covered `JmxReporter` and `metric.reporters`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
