[GitHub] [kafka] clolov commented on a diff in pull request #12505: KAFKA-14133: Replace EasyMock with Mockito in streams tests

[GitBox]

clolov commented on code in PR #12505:
URL: https://github.com/apache/kafka/pull/12505#discussion_r943639431


##########
streams/src/test/java/org/apache/kafka/streams/state/internals/KeyValueStoreBuilderTest.java:
##########
@@ -126,27 +121,15 @@ public void shouldThrowNullPointerIfInnerIsNull() {
             Serdes.String(), new MockTime()));
     }
 
-    @Test

Review Comment:
   As far as I can tell, the behaviour exercised in these tests is never 
enforced in the code so I have no idea how they have been passing up to now. I 
deleted them, but if I am shown to be wrong I will return them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org