jsancio commented on code in PR #12274: URL: https://github.com/apache/kafka/pull/12274#discussion_r943618096
########## raft/src/main/java/org/apache/kafka/raft/internals/FuturePurgatory.java: ########## @@ -56,7 +56,7 @@ CompletableFuture<Long> await(T threshold, long maxWaitTimeMs); /** - * Complete awaiting futures whose associated values are larger than the given threshold value. + * Complete awaiting futures whose associated values are smaller than the given threshold value. Review Comment: Thanks for this fix. I think the phrase "associated values" is still misleading. How about: > Complete awaiting futures whose threshold value from {@link await} is smaller than the given threshold value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org