jolshan commented on PR #12501: URL: https://github.com/apache/kafka/pull/12501#issuecomment-1213313811
> Do we need a test that validates the producer id expiration without transactions? > I was also wondering if we could add better unit tests to test the various scenarios and ensure that everything is wire up correctly. I can add a non transactions test. @dajac are there any other unit test scenarios you are referring to? Main things I see are 1. Transactional expiry is higher than producer ID expiry and transactions are used (currently in the PR) 2. Producer ID expiry without transactions We could also include a test for producer ID expiry that is higher than transactional ID expiry if we think that is useful. (I guess in this case we expect to see idempotent guarantees, but not transactional ones? I think I still need to figure out what that would look like.) Let me know if there is anything else I'm missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
