showuon commented on PR #12500: URL: https://github.com/apache/kafka/pull/12500#issuecomment-1214369765
> Ah, sorry for the delay. I think time.sleep() here is needed here to make the pollTimer timeout. If we removed this, will hang in the coordinator.onJoinPrepare @aiquestion , thanks for the explanation. In that case, don't you think we should make the timer timeout to 0? That is: ```java Timer pollTimer = time.timer(0L); // no need to make the timeout expired here // time.sleep(150); boolean res = coordinator.onJoinPrepare(pollTimer, generationId, memberId); assertFalse(res); ``` If you think this is a good suggestion, could you open another PR to improve it? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
