guozhangwang commented on code in PR #12466:
URL: https://github.com/apache/kafka/pull/12466#discussion_r946203610
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -296,6 +296,75 @@ public void shouldAddTasksToStateUpdater() {
Mockito.verify(stateUpdater).add(task01);
}
+ @Test
+ public void shouldHandleRemovedTasksFromStateUpdater() {
Review Comment:
When adding tests I realized we do not need to handle exceptions by closing
tasks dirty and then re-thrown, but could simply re-throw directly and delegate
to the StreamThread to handle the thrown exception. Will updated accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
