ijuma commented on code in PR #12538:
URL: https://github.com/apache/kafka/pull/12538#discussion_r949628460
##########
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##########
@@ -275,15 +275,15 @@ metaProperties, config, new MetadataRecordSerde(),
metadataPartition, KafkaRaftS
executorService.shutdownNow();
executorService.awaitTermination(5, TimeUnit.MINUTES);
}
- for (ControllerServer controller : controllers.values()) {
- controller.shutdown();
- }
for (BrokerServer brokerServer : brokers.values()) {
brokerServer.shutdown();
}
for (KafkaRaftManager<ApiMessageAndVersion> raftManager :
raftManagers.values()) {
raftManager.shutdown();
}
+ for (ControllerServer controller : controllers.values()) {
+ controller.shutdown();
+ }
Review Comment:
If this is correct, we should probably add a comment explaining it as it's
not obvious why it would work that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
