cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949686749
########## server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java: ########## @@ -72,20 +71,18 @@ import static org.junit.jupiter.api.Assertions.assertTrue; class MetadataVersionTest { - @Test public void testFeatureLevel() { - MetadataVersion[] metadataVersions = MetadataVersion.VERSIONS; - int firstFeatureLevelIndex = Arrays.asList(metadataVersions).indexOf(MetadataVersion.MINIMUM_KRAFT_VERSION); - for (int i = 0; i < firstFeatureLevelIndex; i++) { - assertTrue(metadataVersions[i].featureLevel() < 0); + int i = 0; + while (i < MetadataVersion.VERSIONS.length && Review Comment: Good points. I will separate this out into `testKRaftFeatureLevelsBefore3_0_IV1` and `testKRaftFeatureLevelsAtAndAfter3_0_IV1`, which are hopefully self-explanatory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org