zigarn commented on code in PR #12175:
URL: https://github.com/apache/kafka/pull/12175#discussion_r951165980
##########
core/src/test/scala/unit/kafka/tools/ConsoleProducerTest.scala:
##########
@@ -140,6 +141,29 @@ class ConsoleProducerTest {
assert(reader.parseKey)
}
+ @Test
+ def testParseConfigFile (): Unit = {
Review Comment:
Fixed.
##########
core/src/test/scala/unit/kafka/tools/ConsoleConsumerTest.scala:
##########
@@ -488,6 +488,31 @@ class ConsoleConsumerTest {
assertTrue(formatter.keyDeserializer.get.asInstanceOf[MockDeserializer].isKey)
}
+ @Test
+ def testCustomConfigShouldBePassedToConfigureMethod(): Unit = {
+ val propsFile = TestUtils.tempFile()
+ val propsStream = Files.newOutputStream(propsFile.toPath)
+ propsStream.write("key.deserializer.my-props=abc\n".getBytes())
+ propsStream.write("print.key=false".getBytes())
+ propsStream.close()
+
+ val args = Array(
+ "--bootstrap-server", "localhost:9092",
+ "--topic", "test",
+ "--property", "print.key=true",
+ "--property", "key.deserializer=org.apache.kafka.test.MockDeserializer",
+ "--formatter-config", propsFile.getAbsolutePath
+ )
+ val config = new ConsoleConsumer.ConsumerConfig(args)
+ assertTrue(config.formatter.isInstanceOf[DefaultMessageFormatter])
+ assertTrue(config.formatterArgs.containsKey("key.deserializer.my-props"))
+ val formatter = config.formatter.asInstanceOf[DefaultMessageFormatter]
+ assertTrue(formatter.keyDeserializer.get.isInstanceOf[MockDeserializer])
+ assertEquals(1,
formatter.keyDeserializer.get.asInstanceOf[MockDeserializer].configs.size)
Review Comment:
Fixed.
Also applied on code of previous test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
