C0urante commented on PR #12478: URL: https://github.com/apache/kafka/pull/12478#issuecomment-1224225930
Why construct the latches in `Worker`? Wouldn't it be cleaner to create them in the `RetryWithToleranceOperator` constructor and expose a method in that class to count down the latch, which we could then invoke from tasks inside their `cancel` method? As far as testing goes, can we just mock the latch and leave everything else basically as-is? We should continue to use the `Time` interface for everything except sleeping, so all the existing invocations of `Time::milliseconds` can stay. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
