[GitHub] [kafka] showuon commented on a diff in pull request #12229: MINOR: Include the inner exception stack trace when re-throwing an exception

[GitBox]

showuon commented on code in PR #12229:
URL: https://github.com/apache/kafka/pull/12229#discussion_r956553207


##########
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/HttpAccessTokenRetriever.java:
##########
@@ -326,7 +326,7 @@ static String formatRequestBody(String scope) throws 
IOException {
             return requestParameters.toString();
         } catch (UnsupportedEncodingException e) {
             // The world has gone crazy!
-            throw new IOException(String.format("Encoding %s not supported", 
StandardCharsets.UTF_8.name()));
+            throw new IOException(String.format("Encoding %s not supported", 
StandardCharsets.UTF_8.name()), e);

Review Comment:
   Thanks for the explanation @divijvaidya , yes, I checked and confirmed it 
only output the charset name. So it's safe. @ijuma , any concern/comments here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org