cmccabe commented on code in PR #12571: URL: https://github.com/apache/kafka/pull/12571#discussion_r958914091
########## clients/src/main/java/org/apache/kafka/clients/admin/SupportedVersionRange.java: ########## @@ -36,10 +36,10 @@ public class SupportedVersionRange { * @throws IllegalArgumentException Raised when the condition described above is not met. */ SupportedVersionRange(final short minVersion, final short maxVersion) { - if (minVersion < 1 || maxVersion < 1 || maxVersion < minVersion) { + if (minVersion < 0 || maxVersion < 0 || maxVersion < minVersion) { Review Comment: It is meaningful. If SupportedVersionRange includes 0, that means the feature can be turned off. If SupportedVersionRange does not include 0, the feature can't be turned off (for example, metadata.version on KRaft brokers cannot be 0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org