[GitHub] [kafka] cmccabe commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

[GitBox]

cmccabe commented on code in PR #12596:
URL: https://github.com/apache/kafka/pull/12596#discussion_r965315234


##########
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##########
@@ -147,7 +160,9 @@ class BrokerMetadataListener(
 
   private def maybeStartSnapshot(): Unit = {
     snapshotter.foreach { snapshotter =>
-      if (snapshotter.maybeStartSnapshot(_highestTimestamp, _delta.apply())) {
+      if (metadataFaultOccurred.get()) {
+        trace("Not starting metadata snapshot since we previously had an 
error")

Review Comment:
   Yeah. That's fair.
   
   I guess it's OK like it is for now. I am going to refactor this as part of 
the effort to unify Image handling between broker + controller.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org