jnh5y commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r968982353
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##########
@@ -305,6 +307,36 @@ public void buildAndOptimizeTopology(final boolean
optimizeTopology) {
internalTopologyBuilder.validateCopartition();
}
+ /**
+ * A user can provide either the config OPTIMIZE which means all
optimizations rules will be
+ * applied or they can provide a list of optimization rules.
+ */
+ private void optimizeTopology(final Properties props) {
+ final List<String> optimizationConfigs;
+ if (props == null ||
!props.containsKey(StreamsConfig.TOPOLOGY_OPTIMIZATION_CONFIG)) {
+ optimizationConfigs = new ArrayList<>();
+ optimizationConfigs.add(StreamsConfig.NO_OPTIMIZATION);
+ } else {
+ optimizationConfigs =
StreamsConfig.verifyTopologyOptimizationConfigs(
+ (String)
props.get(StreamsConfig.TOPOLOGY_OPTIMIZATION_CONFIG));
+ }
+ if (optimizationConfigs.contains(StreamsConfig.OPTIMIZE)
+ ||
optimizationConfigs.contains(StreamsConfig.REUSE_KTABLE_SOURCE_TOPICS)) {
+ LOG.debug("Optimizing the Kafka Streams graph for ktable source
nodes");
+ optimizeKTableSourceTopics();
+ }
+ if (optimizationConfigs.contains(StreamsConfig.OPTIMIZE)
+ ||
optimizationConfigs.contains(StreamsConfig.MERGE_REPARTITION_TOPICS)) {
+ LOG.debug("Optimizing the Kafka Streams graph for repartition
nodes");
+ maybeOptimizeRepartitionOperations();
+ }
+ if (optimizationConfigs.contains(StreamsConfig.OPTIMIZE)
+ || optimizationConfigs.contains(StreamsConfig.SELF_JOIN)) {
+ LOG.debug("Optimizing the Kafka Streams graph for self-joins");
+ rewriteSelfJoin(root, new IdentityHashMap<>());
Review Comment:
In this method, could order matter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
