vpapavas commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r969358545
########## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ########## @@ -1644,6 +1668,29 @@ private Map<String, Object> getClientCustomProps() { return props; } + public static List<String> verifyTopologyOptimizationConfigs(final String config) { + final List<String> acceptableConfigs = Arrays.asList( Review Comment: Yes, I have been conflicted about this. I wanted to add it as a static variable as well but I am worried if someone else adds a new rewriting, they might miss it. Whereas in the method, they will for sure see it. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org