guozhangwang commented on code in PR #12659:
URL: https://github.com/apache/kafka/pull/12659#discussion_r974503648
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -785,6 +787,22 @@ private void addTasksToStateUpdater() {
}
}
+ private void pauseTasksInStateUpdater() {
+ for (final Task task : stateUpdater.getUpdatingTasks()) {
Review Comment:
I'm a bit concerned about perf here since this is called for each iteration,
and to be safer we'd need to wrap each as read-only task as we did for
`getTasks`, hence generating a lot of young gen for GCs, but other than the
current approach I have not got to a better solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
