mdedetrich commented on PR #12524:
URL: https://github.com/apache/kafka/pull/12524#issuecomment-1252139067
@cadonna Okay so I have just pushed and rebased the PR with these changes
* As you have rightly pointed out there were a lot of things being
stubbed/tested which made no sense due to peculiarities of how `EasyMock` works
(which I am still trying to get my head around). I believe I have removed most
of the unnecessary `reset`s/stubs. There are still some `verify`'s which can be
argued are pointless (mainly in the setup of the mock), if you still want to
remove these then let me know
* `StreamTaskTest` previously with `EasyMock` used stub exceptions to verify
a method was not meant to be called, i.e.
```java
EasyMock.expectLastCall().andThrow(new AssertionError("Should not have
tried to checkpoint"));
```
This has now been replaced with using `never`, i.e. the above example
translates to `verify(stateManager, never()).checkpoint();` which
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
