divijvaidya commented on code in PR #12465:
URL: https://github.com/apache/kafka/pull/12465#discussion_r975245954


##########
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##########
@@ -990,7 +990,12 @@ private StreamThread createAndAddStreamThread(final long 
cacheSizePerThread, fin
         return streamThread;
     }
 
-    static Metrics getMetrics(final StreamsConfig config, final Time time, 
final String clientId) {
+    // Ensure Mockito stub construct with capture argument for 
KafkaStreamsTest.
+    public static Metrics createMetrics(final MetricConfig metricConfig, final 
List<MetricsReporter> reporters, final Time time, final MetricsContext 
metricsContext) {
+        return new Metrics(metricConfig, reporters, time, metricsContext);
+    }

Review Comment:
   I have changed this in the latest commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to