mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975464527
########## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ########## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty() { final double expectedCloseTaskMetric = 1.0; verifyCloseTaskMetric(expectedCloseTaskMetric, streamsMetrics, metricName); - - EasyMock.verify(stateManager); } @Test public void shouldNotThrowFromStateManagerCloseInCloseDirty() { - EasyMock.expect(stateManager.changelogOffsets()).andStubReturn(Collections.emptyMap()); - stateManager.close(); - EasyMock.expectLastCall().andThrow(new RuntimeException("KABOOM!")).anyTimes(); - EasyMock.replay(stateManager); + doThrow(new RuntimeException("KABOOM!")).when(stateManager).close(); task = createStandbyTask(); task.initializeIfNeeded(); task.suspend(); task.closeDirty(); - EasyMock.verify(stateManager); + verify(stateManager, atLeastOnce()).close(); } @Test public void shouldSuspendAndCommitBeforeCloseClean() { Review Comment: I am unsure what needs to be verified in order? The current version of the test is ```java @Test public void shouldNotThrowFromStateManagerCloseInCloseDirty() { doThrow(new RuntimeException("KABOOM!")).when(stateManager).close(); task = createStandbyTask(); task.initializeIfNeeded(); task.suspend(); task.closeDirty(); } ``` And from what I can tell its testing that the `RuntimeException` ie never thrown when `task.closeDirty()` is called (`task.closeDirty() indirectly calls `stateManager.close()`). The only mock is the `doThrow` so there is nothing to really order? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org