[ https://issues.apache.org/jira/browse/KAFKA-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396325#comment-16396325 ]
ASF GitHub Bot commented on KAFKA-6638: --------------------------------------- lindong28 opened a new pull request #4696: KAFKA-6638; Leader should remove unassigned replica from ISR URL: https://github.com/apache/kafka/pull/4696 During partition reassignment, controller may remove a replica from the replica set while still keeping the replica in the isr set. One solution to fix this issue is to let the controller remove replica from isr set as well. This requires more change in the code because controller needs to update the zookeeper node to change the isr properly. Another solution, which keeps controller simple, is to let leader node remove unassigned replica from the isr set. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Leader should remove unassigned replica from ISR > ------------------------------------------------ > > Key: KAFKA-6638 > URL: https://issues.apache.org/jira/browse/KAFKA-6638 > Project: Kafka > Issue Type: Improvement > Reporter: Dong Lin > Assignee: Dong Lin > Priority: Major > > During partition reassignment, controller may remove a replica from the > replica set while still keeping the replica in the isr set. One solution to > fix this issue is to let the controller remove replica from isr set as well. > This requires more change in the code because controller needs to update the > zookeeper node to change the isr properly. Another solution, which keeps > controller simple, is to let leader node remove unassigned replica from the > isr set. -- This message was sent by Atlassian JIRA (v7.6.3#76005)