showuon commented on code in PR #12679: URL: https://github.com/apache/kafka/pull/12679#discussion_r978205767
########## docs/ops.html: ########## @@ -1815,6 +1815,162 @@ <h4 class="anchor-heading"><a id="remote_jmx" class="anchor-link"></a><a href="# </tr> </tbody></table> +<h5 class="anchor-heading"><a id="kraft_monitoring" class="anchor-link"></a><a href="#kraft_monitoring">KRaft Metrics</a></h5> +All of the following metrics allow monitoring of the KRaft quourm and +<table class="data-table"> + <tbody> + <tr> + <th>Metric/Attribute name</th> + <th>Description</th> + <th>Mbean name</th> + </tr> + <tr> + <td>Current State</td> + <td>The current state of this member; possible values are leader, candidate, voted, follower, unattached.</td> + <td>kafka.raft:type=raft-metrics,name=Current-state</td> Review Comment: Please correct the mbean name: `kafka.server:type=raft-metrics` And below. Thanks. ########## docs/ops.html: ########## @@ -1815,6 +1815,162 @@ <h4 class="anchor-heading"><a id="remote_jmx" class="anchor-link"></a><a href="# </tr> </tbody></table> +<h5 class="anchor-heading"><a id="kraft_monitoring" class="anchor-link"></a><a href="#kraft_monitoring">KRaft Metrics</a></h5> +All of the following metrics allow monitoring of the KRaft quourm and +<table class="data-table"> + <tbody> + <tr> + <th>Metric/Attribute name</th> + <th>Description</th> + <th>Mbean name</th> + </tr> + <tr> + <td>Current State</td> + <td>The current state of this member; possible values are leader, candidate, voted, follower, unattached.</td> + <td>kafka.raft:type=raft-metrics,name=Current-state</td> + </tr> + <tr> + <td>Current Leader</td> + <td>The current quorum leader's id; -1 indicates unknown.</td> + <td>kafka.raft:type=raft-metrics,name=current-leader</td> + </tr> + <tr> + <td>Current Voted</td> + <td>The current voted leader's id; -1 indicates not voted for anyone.</td> + <td>kafka.raft:type=raft-metrics,name=current-vote</td> + </tr> + <tr> + <td>Current Epoch</td> + <td>The current quorum epoch.</td> + <td>kafka.raft:type=raft-metrics,name=current-epoch</td> + </tr> + <tr> + <td>High Watermark</td> + <td>The high watermark maintained on this member; -1 if it is unknown.</td> + <td>kafka.raft:type=raft-metrics,name=high-watermark</td> + </tr> + <tr> + <td>Log End Offset</td> + <td>The current raft log end offset.</td> + <td>kafka.raft:type=raft-metrics,name=log-end-offset</td> + </tr> + <tr> + <td>Election Latency</td> + <td>The time in milliseconds to elect a new leader.</td> + <td>kafka.raft:type=raft-metrics,name=election-latency</td> + </tr> + <tr> + <td>Fetch Records</td> + <td>The average number of records fetched from the leader of the raft quorum.</td> + <td>kafka.raft:type=raft-metrics,name=fetch-records</td> Review Comment: `name: fetch-records-rate` Are your sure it is the avg number? ########## docs/ops.html: ########## @@ -1815,6 +1815,162 @@ <h4 class="anchor-heading"><a id="remote_jmx" class="anchor-link"></a><a href="# </tr> </tbody></table> +<h5 class="anchor-heading"><a id="kraft_monitoring" class="anchor-link"></a><a href="#kraft_monitoring">KRaft Metrics</a></h5> +All of the following metrics allow monitoring of the KRaft quourm and Review Comment: and [what?] ########## docs/ops.html: ########## @@ -1815,6 +1815,162 @@ <h4 class="anchor-heading"><a id="remote_jmx" class="anchor-link"></a><a href="# </tr> </tbody></table> +<h5 class="anchor-heading"><a id="kraft_monitoring" class="anchor-link"></a><a href="#kraft_monitoring">KRaft Metrics</a></h5> +All of the following metrics allow monitoring of the KRaft quourm and +<table class="data-table"> + <tbody> + <tr> + <th>Metric/Attribute name</th> + <th>Description</th> + <th>Mbean name</th> + </tr> + <tr> + <td>Current State</td> + <td>The current state of this member; possible values are leader, candidate, voted, follower, unattached.</td> + <td>kafka.raft:type=raft-metrics,name=Current-state</td> + </tr> + <tr> + <td>Current Leader</td> + <td>The current quorum leader's id; -1 indicates unknown.</td> + <td>kafka.raft:type=raft-metrics,name=current-leader</td> + </tr> + <tr> + <td>Current Voted</td> + <td>The current voted leader's id; -1 indicates not voted for anyone.</td> + <td>kafka.raft:type=raft-metrics,name=current-vote</td> + </tr> + <tr> + <td>Current Epoch</td> + <td>The current quorum epoch.</td> + <td>kafka.raft:type=raft-metrics,name=current-epoch</td> + </tr> + <tr> + <td>High Watermark</td> + <td>The high watermark maintained on this member; -1 if it is unknown.</td> + <td>kafka.raft:type=raft-metrics,name=high-watermark</td> + </tr> + <tr> + <td>Log End Offset</td> + <td>The current raft log end offset.</td> + <td>kafka.raft:type=raft-metrics,name=log-end-offset</td> + </tr> + <tr> + <td>Election Latency</td> + <td>The time in milliseconds to elect a new leader.</td> + <td>kafka.raft:type=raft-metrics,name=election-latency</td> + </tr> + <tr> + <td>Fetch Records</td> + <td>The average number of records fetched from the leader of the raft quorum.</td> + <td>kafka.raft:type=raft-metrics,name=fetch-records</td> + </tr> + <tr> + <td>Append Records</td> + <td>The average number of records appended per sec as the leader of the raft quorum.</td> + <td>kafka.raft:type=raft-metrics,name=append-records</td> + </tr> + <tr> + <td>Poll Idle Ratio</td> + <td>The average fraction of time the client's poll() is idle as opposed to waiting for the user code to process records.</td> + <td>kafka.raft:type=raft-metrics,name=poll-idle-ratio</td> Review Comment: name=poll-idle-ratio-avg ########## docs/ops.html: ########## @@ -1815,6 +1815,162 @@ <h4 class="anchor-heading"><a id="remote_jmx" class="anchor-link"></a><a href="# </tr> </tbody></table> +<h5 class="anchor-heading"><a id="kraft_monitoring" class="anchor-link"></a><a href="#kraft_monitoring">KRaft Metrics</a></h5> +All of the following metrics allow monitoring of the KRaft quourm and +<table class="data-table"> + <tbody> + <tr> + <th>Metric/Attribute name</th> + <th>Description</th> + <th>Mbean name</th> + </tr> + <tr> + <td>Current State</td> + <td>The current state of this member; possible values are leader, candidate, voted, follower, unattached.</td> + <td>kafka.raft:type=raft-metrics,name=Current-state</td> + </tr> + <tr> + <td>Current Leader</td> + <td>The current quorum leader's id; -1 indicates unknown.</td> + <td>kafka.raft:type=raft-metrics,name=current-leader</td> + </tr> + <tr> + <td>Current Voted</td> + <td>The current voted leader's id; -1 indicates not voted for anyone.</td> + <td>kafka.raft:type=raft-metrics,name=current-vote</td> + </tr> + <tr> + <td>Current Epoch</td> + <td>The current quorum epoch.</td> + <td>kafka.raft:type=raft-metrics,name=current-epoch</td> + </tr> + <tr> + <td>High Watermark</td> + <td>The high watermark maintained on this member; -1 if it is unknown.</td> + <td>kafka.raft:type=raft-metrics,name=high-watermark</td> + </tr> + <tr> + <td>Log End Offset</td> + <td>The current raft log end offset.</td> + <td>kafka.raft:type=raft-metrics,name=log-end-offset</td> + </tr> + <tr> + <td>Election Latency</td> + <td>The time in milliseconds to elect a new leader.</td> + <td>kafka.raft:type=raft-metrics,name=election-latency</td> Review Comment: The description of election latency is not clear to me. Maybe: `The time in milliseconds spent on electing a leader.` WDYT? ########## docs/ops.html: ########## @@ -1815,6 +1815,162 @@ <h4 class="anchor-heading"><a id="remote_jmx" class="anchor-link"></a><a href="# </tr> </tbody></table> +<h5 class="anchor-heading"><a id="kraft_monitoring" class="anchor-link"></a><a href="#kraft_monitoring">KRaft Metrics</a></h5> +All of the following metrics allow monitoring of the KRaft quourm and +<table class="data-table"> + <tbody> + <tr> + <th>Metric/Attribute name</th> + <th>Description</th> + <th>Mbean name</th> + </tr> + <tr> + <td>Current State</td> + <td>The current state of this member; possible values are leader, candidate, voted, follower, unattached.</td> + <td>kafka.raft:type=raft-metrics,name=Current-state</td> + </tr> + <tr> + <td>Current Leader</td> + <td>The current quorum leader's id; -1 indicates unknown.</td> + <td>kafka.raft:type=raft-metrics,name=current-leader</td> + </tr> + <tr> + <td>Current Voted</td> + <td>The current voted leader's id; -1 indicates not voted for anyone.</td> + <td>kafka.raft:type=raft-metrics,name=current-vote</td> + </tr> + <tr> + <td>Current Epoch</td> + <td>The current quorum epoch.</td> + <td>kafka.raft:type=raft-metrics,name=current-epoch</td> + </tr> + <tr> + <td>High Watermark</td> + <td>The high watermark maintained on this member; -1 if it is unknown.</td> + <td>kafka.raft:type=raft-metrics,name=high-watermark</td> + </tr> + <tr> + <td>Log End Offset</td> + <td>The current raft log end offset.</td> + <td>kafka.raft:type=raft-metrics,name=log-end-offset</td> + </tr> + <tr> + <td>Election Latency</td> + <td>The time in milliseconds to elect a new leader.</td> + <td>kafka.raft:type=raft-metrics,name=election-latency</td> Review Comment: Also, there is no `election-latency` metrics, only `election-latency-avg` `election-latency-max` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org