[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

[GitBox]

mdedetrich commented on code in PR #12524:
URL: https://github.com/apache/kafka/pull/12524#discussion_r984359623


##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java:
##########
@@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty() {
 
         final double expectedCloseTaskMetric = 1.0;
         verifyCloseTaskMetric(expectedCloseTaskMetric, streamsMetrics, 
metricName);
-
-        EasyMock.verify(stateManager);
     }
 
     @Test
     public void shouldNotThrowFromStateManagerCloseInCloseDirty() {
-        
EasyMock.expect(stateManager.changelogOffsets()).andStubReturn(Collections.emptyMap());
-        stateManager.close();
-        EasyMock.expectLastCall().andThrow(new 
RuntimeException("KABOOM!")).anyTimes();
-        EasyMock.replay(stateManager);
+        doThrow(new RuntimeException("KABOOM!")).when(stateManager).close();
 
         task = createStandbyTask();
         task.initializeIfNeeded();
 
         task.suspend();
         task.closeDirty();
 
-        EasyMock.verify(stateManager);
+        verify(stateManager, atLeastOnce()).close();
     }
 
     @Test
     public void shouldSuspendAndCommitBeforeCloseClean() {
         stateManager.close();
-        EasyMock.expectLastCall();
+        verify(stateManager, atLeastOnce()).close();
         stateManager.checkpoint();

Review Comment:
   Are you checking the latest state of the PR and pointing out 
`verify(stateManager, atLeastOnce()).close();`? There is a 
`verify(stateManager, atLeastOnce()).close();` but its at the end of the test 
and its now ordered, this is the current latest state
   
   ```java
   @Test
   public void shouldSuspendAndCommitBeforeCloseClean() {
       when(stateManager.changelogOffsets())
           .thenReturn(Collections.singletonMap(partition, 60L));
       final InOrder stateManagerOrdered = inOrder(stateManager);
       stateManager.close();
       stateManager.checkpoint();
       stateManagerOrdered.verify(stateManager, times(1)).checkpoint();
       when(stateManager.changelogOffsets())
               .thenReturn(Collections.singletonMap(partition, 60L));
       final MetricName metricName = setupCloseTaskMetric();
   
       task = createStandbyTask();
       task.initializeIfNeeded();
       task.suspend();
       task.prepareCommit();
       task.postCommit(true);
       task.closeClean();
   
       assertEquals(Task.State.CLOSED, task.state());
   
       final double expectedCloseTaskMetric = 1.0;
       verifyCloseTaskMetric(expectedCloseTaskMetric, streamsMetrics, 
metricName);
   
       verify(stateManager).changelogOffsets();
       stateManagerOrdered.verify(stateManager, atLeastOnce()).close();
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org