hshi2022 commented on code in PR #12634:
URL: https://github.com/apache/kafka/pull/12634#discussion_r984918122
##########
core/src/main/scala/kafka/server/ClientRequestQuotaManager.scala:
##########
@@ -30,6 +30,9 @@ import scala.jdk.CollectionConverters._
object ClientRequestQuotaManager {
val QuotaRequestPercentDefault = Int.MaxValue.toDouble
val NanosToPercentagePerSecond = 100.0 / TimeUnit.SECONDS.toNanos(1)
+ // Since exemptSensor is for all clients and has a constant name, we do not
expire exemptSensor and only
+ // create once.
+ val DefaultInactiveExemptSensorExpirationTimeSeconds = Long.MaxValue
Review Comment:
I prefer using DefaultInactiveExemptSensorExpirationTimeSeconds because the
value could be updated if needed. And it aligns with the code pattern, e.g., we
also have QuotaRequestPercentDefault which has Int.MaxValue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
