C0urante commented on PR #12434: URL: https://github.com/apache/kafka/pull/12434#issuecomment-1276267039
Apologies for the delay @zigarn, and thank you for sticking with this. I'm still not sure we should be relying on the Scala `LogCaptureAppender`, but I don't want to ask you to put more work into this PR (you've already done plenty!), and I don't want to block this PR on someone else re-reviewing #10528. What I'd like to do is merge this PR, then on #10528: - Rebase onto the latest trunk - Revert the changes to the Scala `LogCaptureAppender` introduced in this PR - Update the `RestServerTest` to use the Java `LogCaptureAppender` - Merge #10528 (it's already been approved and, although I was hoping we could get another look at it, it's technically acceptable to merge it now as-is) Is that alright with you? And again, thank you for sticking with this PR, it really is a valuable improvement and I'd like to see it merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
